nkuprins commented on PR #920: URL: https://github.com/apache/fesod/pull/920#issuecomment-5237630010
Hi @bengbengbalabalabeng. I noticed that this cool PR introduces `AnnotatedClassUtils`. Have you read #989 by any chance? It seems that the issue raised there is also related to `AnnotatedClassUtils`. I would appreciate hearing your opinion on this :) I ask this because if this gets merged and later `ClassUtils` refactoring gets approved, then we **may** have two `@Deprecated` problems at once. Besides, in `AnnotatedClassUtils#doDeclaredFields` (line 317) there's `indexFieldMap.remove(index)`. That's the bug #977 fixed in `ClassUtils`, where it's now `indexFieldMap.remove(key)`. Not sure if you already noticed that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
