bengbengbalabalabeng commented on code in PR #981:
URL: https://github.com/apache/fesod/pull/981#discussion_r3728686049
##########
fesod-sheet/src/main/java/org/apache/fesod/sheet/analysis/v03/handlers/LabelSstRecordHandler.java:
##########
@@ -45,17 +46,29 @@ public class LabelSstRecordHandler extends
AbstractXlsRecordHandler implements I
@Override
public void processRecord(XlsReadContext xlsReadContext, Record record) {
LabelSSTRecord lsrec = (LabelSSTRecord) record;
+ int originalColumnIndex = lsrec.getColumn();
+
+ List<Integer> includeColumnIndexes = null;
+
+ includeColumnIndexes =
xlsReadContext.readSheetHolder().getReadSheet().getColumnIndexes();
Review Comment:
The initial assignment `null` is redundant.
##########
fesod-sheet/src/main/java/org/apache/fesod/sheet/analysis/v03/handlers/NumberRecordHandler.java:
##########
@@ -43,8 +44,22 @@ public class NumberRecordHandler extends
AbstractXlsRecordHandler implements Ign
@Override
public void processRecord(XlsReadContext xlsReadContext, Record record) {
NumberRecord nr = (NumberRecord) record;
+ int originalColumnIndex = nr.getColumn();
+
+ List<Integer> includeColumnIndexes = null;
+
+ includeColumnIndexes =
xlsReadContext.readSheetHolder().getReadSheet().getColumnIndexes();
Review Comment:
The initial assignment null is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
