delei commented on PR #979:
URL: https://github.com/apache/fesod/pull/979#issuecomment-5166403293
> 1. At `docs/sheet/fill/#simple-fill`
>
> The change was from `John Doe` to `John`.
> However, `C2`, `D2` still hold `John Doe`.
>
> I am also confused by this change, because other sections still use
`John Doe`. For consistency, it might be better to stick with 1 option for all
sections, either `John` or `John Doe`.
>
> Btw, I just noticed a problem with the `data()` function. The **write**
docs define their `data()`, but the **fill** docs don't. This is at least
inconsistent. Also, it can be confusing for **junior** readers.
> Do you think it might be worth adding smth like this:
>
> ### Data List
> The examples further down all fill from this helper:
>
> ```java
> private List<FillData> data() {
> List<FillData> list = ListUtils.newArrayList();
> for (int i = 0; i < 10; i++) {
> FillData fillData = new FillData();
> fillData.setName("John Doe" + i);
> fillData.setNumber(5.2);
> fillData.setDate(new Date());
> list.add(fillData);
> }
> return list;
> }
> ```
>
> If we do this, note that at `docs/sheet/fill/#horizontal-fill` in the
results table, you removed columns from `G` to `L`. This implies cutting the
filled data from 10 items to 4, which would violate `data()` count. The fix
would be to add a `⋯` column, as we do at
`docs/sheet/fill/#fill-multiple-lists-together` in the results tables.
>
> 2. At `docs/sheet/write/image.md:191`
>
> I think there is a typo.`Fefault` should be `Default`
> 3. At `docs/sheet/write/extra.md:25`
>
> The merged section was removed, but we still mention it: `This chapter
introduces how to write extra information such as comments, hyperlinks,
formulas, merged cells, etc.` The fix:
> `This chapter introduces how to write extra information such as
comments, hyperlinks, formulas, etc.`
Thank you for the review. These have been revised and completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
