diysimon opened a new pull request, #21558:
URL: https://github.com/apache/echarts/pull/21558
close #21551
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Fixes the missing `cursor` support on `candlestick` series and adds a manual
test page for verification.
### Fixed issues
- #21551: `cursor` does not take effect on `candlestick` series
## Details
### Before: What was the problem?
`cursor` is a supported option on some series types, but it did not work on
`candlestick`.
The main reason was that `candlestick` view did not forward the cursor
option to zrender elements:
- in normal mode, the candlestick path did not read
`itemModel.getShallow('cursor')`
- in large mode, the large candlestick paths did not apply `series.cursor`
As a result, hovering candlestick elements still showed the default cursor.
### After: How does it behave after the fixing?
After this change:
- `series.cursor` works on `candlestick` in normal mode
- `data[i].cursor` also works in normal mode
- `series.cursor` works on `candlestick` in large mode
The fix is kept minimal by only wiring the existing cursor option through
`CandlestickView` and adding a manual test page:
- `test/candlestick-cursor.html`
The test page includes:
- a normal-mode candlestick chart similar to the `candlestick-sh` example
- a large-mode candlestick chart for verifying the large rendering path
## Document Info
One of the following should be checked.
- [ ] This PR doesn't relate to document changes
- [x] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### Security Checking
- [ ] This PR uses security-sensitive Web APIs.
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
- `test/candlestick-cursor.html`
### Merging options
- [x] Please squash the commits into a single one when merging.
### Other information
Local verification:
- `eslint`
- `tsc --noEmit`
- manual verification in `test/candlestick-cursor.html`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
