plainheart commented on code in PR #21176:
URL: https://github.com/apache/echarts/pull/21176#discussion_r2267656346
##########
src/theme/dark.ts:
##########
@@ -103,6 +103,16 @@ const theme = {
toolbox: {
iconStyle: {
borderColor: color.accent50
+ },
+ feature: {
+ dataView: {
+ backgroundColor: color.background,
Review Comment:
Can reuse the `background` constant that was declared at line 23.
```suggestion
backgroundColor: backgroundColor,
```
And please @Ovilia review if the proposed dark colors for the toolbox are
suitable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
