kfaraz commented on code in PR #19697:
URL: https://github.com/apache/druid/pull/19697#discussion_r3595304255
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java:
##########
@@ -326,6 +330,15 @@ int computeOptimalTaskCount(CostMetrics metrics)
);
emitter.emit(getMetricBuilder().setMetric(OPTIMAL_LAG_COST_METRIC,
optimalCost.lagCost()));
emitter.emit(getMetricBuilder().setMetric(OPTIMAL_IDLE_COST_METRIC,
optimalCost.idleCost()));
+
+ final double costDropPercent = (currentCost.totalCost() -
optimalCost.totalCost()) / currentCost.totalCost();
+ if (costDropPercent < config.getMinCostDropPercentForScaling()) {
Review Comment:
Yep, let me fix this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
