clintropolis commented on code in PR #19600: URL: https://github.com/apache/druid/pull/19600#discussion_r3462887623
########## processing/src/main/java/org/apache/druid/segment/CursorFactory.java: ########## Review Comment: `CursorFactory` is sort indirectly a `@PublicApi` via `Segment#as` and also a sort of very low level extension point for custom segment implementations, so adding a new method with no default means extension writers would need to implement it and recompile for functionality that is currently at least off by default, so it seemed nicer to implement it so that they don't need to recompile immediately, making this async stuff more opt-in. I was thinking if something changes that makes it so that this path can be hit by default then I would change this to remove the default because at that point it really would need to be implemented -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
