clintropolis commented on code in PR #19613: URL: https://github.com/apache/druid/pull/19613#discussion_r3456258253
########## processing/src/main/java/org/apache/druid/query/QueryContexts.java: ########## @@ -126,6 +126,7 @@ public class QueryContexts public static final String NO_PROJECTIONS = "noProjections"; public static final String FORCE_PROJECTION = "forceProjections"; public static final String USE_PROJECTION = "useProjection"; + public static final String PROJECTION_TRACE = "projectionTrace"; Review Comment: yea, i considered the noise briefly too, but then said to myself it was ok though because the noisy SQL logs are all on the broker, while these logs are only going to be on the historicals and realtime servers, per segment. If you really want to add a new flag, i still think we should also do this logging if `debug` is set, so that way someone wanting "all the logs" doesn't have to set a bunch of different flags, so the `logTrace` method could check either `projectionTrace` or `debug` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
