abhishekrb19 opened a new pull request, #19615:
URL: https://github.com/apache/druid/pull/19615
With https://github.com/apache/druid/pull/19571, when a concurrent replace
task
upgrades a still-appending streaming task, the upgraded (new-version)
copy of
each append segment previously adopted the pending segment's plain
NumberedShardSpec,
dropping the DimensionValueSetShardSpec stamped at publish time. This
made upgraded
segments unprunable by the broker.
The upgraded copy now takes its partition number and core-partition count
from the pending segment while carrying forward the original segment's
partitionDimensionValues when it is a DimensionValueSetShardSpec. The
value-set guarantee holds because the upgraded copy serves the same rows
as the original append segment.
This does not change the fact that pending segments are always allocated
as numbered
shard specs, since tasks still advertise them as such — the value-set
shard spec
currently applies only to recently-published segments.
This PR has:
- [x] been self-reviewed.
- [x] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
