jaykanakiya commented on code in PR #19596:
URL: https://github.com/apache/druid/pull/19596#discussion_r3440382823
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunnerTest.java:
##########
@@ -580,6 +580,103 @@ public void testFeatureOffReturnsSegmentUnchanged()
throws Exception
Assert.assertSame("With the feature off the segment must be returned
unchanged", segment, annotated);
}
+ /** Boundary: observed values exactly equal the cap, dim must still stamp. */
+ @Test
+ public void testCapAtBoundaryStampsValuesNormally() throws Exception
+ {
+ final TestSeekableStreamIndexTaskRunner runner = createRunner(
+ ImmutableMap.of("partition", "0"),
+ ImmutableMap.of("partition", "100")
+ );
+ Mockito.when(task.getTuningConfig().getStreamingPartitionsSpec())
+ .thenReturn(new StreamingPartitionsSpec(List.of("tenant"), 3));
+
+ final DataSegment segment = createSingleSegment();
+ observe(runner, segment.getId(), "tenant", "tenant_a", "tenant_b",
"tenant_c");
+
+ final DataSegment annotated =
runner.annotateSegmentWithPartitionDimensionValues(segment);
+
+ Assert.assertTrue(annotated.getShardSpec() instanceof
DimensionValueSetShardSpec);
+ Assert.assertEquals(
+ Arrays.asList("tenant_a", "tenant_b", "tenant_c"),
+ ((DimensionValueSetShardSpec)
annotated.getShardSpec()).getPartitionDimensionValues().get("tenant")
+ );
+ }
+
+ /** Over-cap: dim is omitted from the filter map; segment still gets a
DimensionValueSetShardSpec. */
+ @Test
+ public void testCapExceededOmitsDimensionFromFilterMap() throws Exception
+ {
+ final TestSeekableStreamIndexTaskRunner runner = createRunner(
Review Comment:
Added embedded test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
