FrankChen021 commented on code in PR #19598:
URL: https://github.com/apache/druid/pull/19598#discussion_r3435731414
##########
server/src/main/java/org/apache/druid/server/DruidNode.java:
##########
@@ -139,7 +157,8 @@ public DruidNode(
@JacksonInject(useInput = OptBoolean.TRUE) @Named("tlsServicePort")
@JsonProperty("tlsPort") Integer tlsPort,
@JsonProperty("enablePlaintextPort") Boolean enablePlaintextPort,
@JsonProperty("enableTlsPort") boolean enableTlsPort,
- @JsonProperty("labels") @Nullable Map<String, String> labels
+ @JsonProperty("labels") @Nullable Map<String, String> labels,
+ @JsonProperty("advertisedPlaintextPort") Integer advertisedPlaintextPort
Review Comment:
[P1] Preserve the labels-taking DruidNode constructor
Adding advertisedPlaintextPort to the existing @JsonCreator constructor
removes the previous nine-argument overload that accepted labels. Existing
source in DruidNodeTest still calls new DruidNode(..., labels), for example the
equality and serde tests, and those calls no longer match any constructor, so
the server module will not compile. Please keep a nine-argument overload that
delegates with a null advertisedPlaintextPort, or update all local call sites
while preserving source compatibility intentionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
