dprmfl commented on code in PR #19231:
URL: https://github.com/apache/druid/pull/19231#discussion_r3426017876
##########
sql/src/main/java/org/apache/druid/sql/avatica/DruidMeta.java:
##########
@@ -804,6 +816,8 @@ private DruidConnection openDruidConnection(
final Map<String, Object> context
)
{
+ String remoteAddress = THREAD_LOCAL_REMOTE_ADDRESS.get();
Review Comment:
https://github.com/apache/druid/pull/19231/commits/4d5460d9d63587facf53051ab9dc5c978762fb29
- fixed. The remote address is no longer frozen on DruidConnection at open
time. Since the JSON/Protobuf handlers already set THREAD_LOCAL_REMOTE_ADDRESS
on every RPC, createStatement and prepare now read it at call time and pass it
down, so request logs and the remoteAddress metric are attributed to the actual
caller of each request rather than the connection opener.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
