FrankChen021 commented on code in PR #19566:
URL: https://github.com/apache/druid/pull/19566#discussion_r3420711560
##########
distribution/bin/check-licenses.py:
##########
@@ -299,6 +299,8 @@ def build_compatible_license_names():
compatible_licenses['Mozilla Public License Version 2.0'] = 'Mozilla
Public License Version 2.0'
compatible_licenses['Mozilla Public License, Version 2.0'] = 'Mozilla
Public License Version 2.0'
+ compatible_licenses['MPL 1.1'] = 'Apache License version 2.0'
Review Comment:
[P2] Do not canonicalize MPL 1.1 as Apache 2.0
This map is used to canonicalize the license reported by Maven before
comparing it to `licenses.yaml`, so mapping `MPL 1.1` to `Apache License
version 2.0` makes a dependency whose POM reports MPL match an Apache-only
registration. The updated Netty tcnative entry remains recorded as Apache 2.0
only, which hides the MPL terms from license/notice metadata. Please
canonicalize MPL 1.1 to its own license name and update the affected license
metadata, or handle the dependency's dual/non-Apache licensing explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
