jtuglu1 commented on code in PR #19572:
URL: https://github.com/apache/druid/pull/19572#discussion_r3415928452
##########
processing/src/main/java/org/apache/druid/audit/RequestInfo.java:
##########
@@ -72,6 +83,19 @@ public String getQueryParams()
return queryParams;
}
+ /**
+ * Value of the {@link AuditManager#X_DRUID_TRACE_ID} header on the inbound
HTTP request,
+ * if present. Null otherwise. Carried through so audit consumers can
correlate audit
+ * events with the originating distributed-trace ID.
+ */
+ @JsonProperty
+ @JsonInclude(JsonInclude.Include.NON_NULL)
+ @Nullable
+ public String getTraceId()
Review Comment:
I wonder if instead of a hard-coded traceID into the requestinfo, we make a
client-supplied metadata map? This would allow the user to extract the fields
they find useful (and allow future fields to be added without a code change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
