capistrant commented on code in PR #19577: URL: https://github.com/apache/druid/pull/19577#discussion_r3404280923
########## processing/src/main/java/org/apache/druid/segment/PhysicalSegmentColumnInspector.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment; + +import javax.annotation.Nullable; + +/** + * Interface for methods describing the columns of physical segments such as {@link QueryableIndexSegment} and + * {@link IncrementalIndexSegment} that is not typically used at query time (outside of metadata queries). + * <p> + * For general metadata information about a segment that is not column specific, use {@link PhysicalSegmentInspector} + * instead. + */ +public interface PhysicalSegmentColumnInspector extends ColumnInspector +{ + /** + * Returns the minimum value of the provided column, if known through an index, dictionary, or cache. Returns null + * if not known. Does not scan the column to find the minimum value. + */ + @Nullable + Comparable getMinValue(String column); + + /** + * Returns the minimum value of the provided column, if known through an index, dictionary, or cache. Returns null Review Comment: ```suggestion * Returns the maximum value of the provided column, if known through an index, dictionary, or cache. Returns null ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
