amaechler opened a new pull request, #19576: URL: https://github.com/apache/druid/pull/19576
Fixes #18373. I came across @kgyrtkirk's issue above (#18373) which was auto-closed. Addressing the few spotbug warnings was straight-forward, especially with Claude doing all the work. This PR removes the pin so the plugin's matching default, 4.9.3, is used. SpotBugs 4.9 ships some new "detectors". Running `mvn spotbugs:check` over all modules produced 17 new findings, handled as follows: - Excluded the new `AT_*` atomicity patterns in `spotbugs-exclude.xml`, alongside the already-excluded `AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION`. The flagged sites rely on external synchronization. - Excluded `HSM_HIDING_METHOD`. `InvalidSqlInput` hides the static `InvalidInput.exception()` factory methods by design. - Removed two `@SuppressFBWarnings` annotations that the new `UselessSuppressionDetector` reports as unnecessary. This PR has: - [x] been self-reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
