clintropolis commented on code in PR #19565:
URL: https://github.com/apache/druid/pull/19565#discussion_r3382822045
##########
processing/src/main/java/org/apache/druid/segment/loading/PartialClusterGroupLoadSpec.java:
##########
@@ -72,10 +71,9 @@ public PartialClusterGroupLoadSpec(
)
{
super(delegate, fingerprint, jsonMapper);
- Preconditions.checkArgument(
- !CollectionUtils.isNullOrEmpty(clusterGroupIndices),
- "clusterGroupIndices must not be null or empty"
- );
+ // An empty index list is used when a cluster-group matcher applies to a
(clustered) segment but no configured
+ // pattern matches its cluster groups. The historical-side partial loader
honors this by loading nothing.
+ Preconditions.checkNotNull(clusterGroupIndices, "clusterGroupIndices");
Review Comment:
yea, this will be the case until partial load stuff is fully merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
