capistrant opened a new pull request, #19559:
URL: https://github.com/apache/druid/pull/19559
### Description
Allow configuring `segmentLoadAheadCount` for dart workers via local runtime
property. This unlocks flexibility in situations where you do not want to rely
on a controller provided context value to control this property. It can be
powerful in situations where you deploy multiple tiers of historicals on
disperate hardware, and would like to customize the value to maximize a given
hardware spec's capabilities. unset by default, which maintains behavior that
already exists - the controller provided context provides the value OR a
default `2 * threads` is used.
#### Release note
Add dart worker runtime property
`druid.msq.dart.worker.segmentLoadAheadCount` to allow worker local
configuration of `segmentLoadAheadCount`. If configured to be `> 0` for a
worker, this becomes the default `segmentLoadAheadCount` value for the worker.
If the controller also sends `segmentLoadAheadCount` in the context, the larger
one is picked. If not set, the worker will either use the controller provided
context value or the default `2 * threads` if nothing is set in context.
<hr>
##### Key changed/added classes in this PR
* `DartWorkerConfig`
* `DartWorkerContext`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
