FrankChen021 commented on code in PR #19514:
URL: https://github.com/apache/druid/pull/19514#discussion_r3356171335
##########
services/src/main/java/org/apache/druid/cli/CliCoordinator.java:
##########
@@ -178,6 +179,7 @@ protected List<? extends Module> getModules()
modules.add(new QueryableModule());
}
+ modules.add(new RegexEngineModule());
Review Comment:
[P1] Avoid installing RegexEngineModule twice for coordinator-as-overlord
CliCoordinator now always adds RegexEngineModule before the
coordinator/overlord split, but when beOverlord is true it then appends
CliOverlord.getModules(false), whose list also includes RegexEngineModule. Both
modules call JsonConfigProvider.bind for RegexConfig, so
coordinator-as-overlord startup gets duplicate explicit bindings, matching the
adjacent LookupSerdeModule case this method already avoids, and fails before
serving. Only add the regex module on the non-overlord branch, or move it to
the shared core module list and remove the per-service copies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
