clintropolis commented on code in PR #19512:
URL: https://github.com/apache/druid/pull/19512#discussion_r3336907009
##########
processing/src/test/java/org/apache/druid/math/expr/VectorExprResultConsistencyTest.java:
##########
@@ -784,8 +786,10 @@ public static void testExpressionRandomizedBindings(
final int numIterations
)
{
- for (int iterations = 0; iterations < numIterations; iterations++) {
- assertEvalsMatch(expr, parsed, makeRandomizedBindings(VECTOR_SIZE,
types));
+ for (int vectorSize : VECTOR_SIZES) {
Review Comment:
there are tests with both non-existent identifier and null constant, so i
think this is covered,
https://github.com/apache/druid/blob/master/processing/src/test/java/org/apache/druid/math/expr/VectorExprResultConsistencyTest.java#L222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
