FrankChen021 commented on code in PR #19378:
URL: https://github.com/apache/druid/pull/19378#discussion_r3147672761
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScalerConfig.java:
##########
@@ -97,9 +105,12 @@ public CostBasedAutoScalerConfig(
// Cost function weights with defaults
this.lagWeight = Configs.valueOrDefault(lagWeight, DEFAULT_LAG_WEIGHT);
this.idleWeight = Configs.valueOrDefault(idleWeight, DEFAULT_IDLE_WEIGHT);
- this.useTaskCountBoundaries =
Configs.valueOrDefault(useTaskCountBoundaries, false);
- this.highLagThreshold = Configs.valueOrDefault(highLagThreshold, -1);
- this.minScaleUpDelay = Configs.valueOrDefault(minScaleUpDelay,
Duration.millis(this.minTriggerScaleActionFrequencyMillis));
+ this.useTaskCountBoundariesOnScaleUp =
Configs.valueOrDefault(useTaskCountBoundariesOnScaleUp, false);
Review Comment:
[P2] Legacy boundary setting is accepted but ignored
The constructor still accepts the legacy `useTaskCountBoundaries` property,
but the new scale-up/down fields are initialized only from
`useTaskCountBoundariesOnScaleUp` and `useTaskCountBoundariesOnScaleDown`.
Existing supervisor specs with `useTaskCountBoundaries: true` will silently
lose the scale-up boundary after upgrade, allowing unbounded jumps to any
candidate task count. Map the legacy value to the new fields when the new
fields are absent, or reject/document a breaking config change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
