FrankChen021 commented on code in PR #19002:
URL: https://github.com/apache/druid/pull/19002#discussion_r3141742663
##########
pom.xml:
##########
@@ -930,6 +947,11 @@
<artifactId>protobuf-java</artifactId>
<version>${protobuf.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.api.grpc</groupId>
+ <artifactId>proto-google-common-protos</artifactId>
Review Comment:
[P2] Update licenses.yaml for newly managed transitive versions
This PR manages proto-google-common-protos at 2.48.0 and kotlin-stdlib-jdk8
at 1.9.25, but licenses.yaml still registers proto-google-common-protos as
2.28.0 and kotlin-stdlib-jdk8 under the 1.8.21 entry.
distribution/bin/check-licenses.py keys licenses by exact
groupId/artifactId/version, so the apache-release license check can report
these new versions as missing unless licenses.yaml is updated.
##########
pom.xml:
##########
@@ -620,7 +637,7 @@
<dependency>
<groupId>com.github.luben</groupId>
<artifactId>zstd-jni</artifactId>
- <version>1.5.2-3</version>
+ <version>1.5.6-6</version>
Review Comment:
[P2] Update ZSTD size-sensitive tests for the zstd-jni bump
Bumping zstd-jni to 1.5.6-6 changes the native compressor used by the ZSTD
test path, but the PR leaves the exact serialized-size assertions in
BlockCompressedPayloadWriterReaderTest and CellWriterReaderTest unchanged. The
prepared packet already notes BlockCompressedPayloadWriterReaderTest is broken
by this upgrade, so the processing tests remain failing unless the expected
sizes are updated or the ZSTD assertions stop depending on exact compressed
length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
