FrankChen021 commented on code in PR #19004:
URL: https://github.com/apache/druid/pull/19004#discussion_r3141623611
##########
processing/src/main/java/org/apache/druid/segment/QueryableIndexCursorHolder.java:
##########
@@ -672,14 +676,19 @@ private CursorResources(
Interval interval,
@Nullable Filter filter,
boolean cursorAutoArrangeFilters,
- @Nullable QueryMetrics<? extends Query<?>> metrics
+ @Nullable QueryMetrics<? extends Query<?>> metrics,
+ boolean disableVirtualColumnBitmapIndexes
)
{
this.closer = Closer.create();
this.columnCache = new ColumnCache(index, virtualColumns, closer);
this.timeBoundaryInspector = timeBoundaryInspector;
try {
this.numRows = index.getNumRows();
+ final ColumnIndexSelector indexSelectorForFilters =
Review Comment:
[P2] Search queries still bypass this virtual-column index guard
This only wraps the selector used by cursor filter bundles, but
`SearchQuery` has a separate index-only path in `UseIndexesStrategy` that still
constructs plain `ColumnCache` selectors for `partitionDimensionList`,
`makeTimeFilteredBitmap`, and `IndexOnlyExecutor`. A search query with
`maxVirtualColumnsForBitmapIndexing` set low and a virtual search dimension or
virtual-column filter can still choose and execute the bitmap-index plan, so
the new query context is not honored for one of the query types that accepts
virtual columns. Please apply the same disabling selector in the search index
strategy, or document/limit the parameter to cursor-backed query paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
