FrankChen021 commented on code in PR #19056: URL: https://github.com/apache/druid/pull/19056#discussion_r3141586014
########## extensions-core/kubernetes-extensions/src/main/java/org/apache/druid/k8s/discovery/DefaultK8sApiClient.java: ########## @@ -33,6 +33,7 @@ import io.kubernetes.client.openapi.models.V1PodList; import io.kubernetes.client.util.PatchUtils; import io.kubernetes.client.util.Watch; +import okhttp3.internal.http2.StreamResetException; Review Comment: P2 Avoid depending on OkHttp internal exception type The fix imports okhttp3.internal.http2.StreamResetException, which is an internal OkHttp class rather than a supported API. This makes the extension compile- and behavior-sensitive to OkHttp internals, so a Kubernetes client or OkHttp upgrade can break this code even if public APIs remain compatible. Since StreamResetException is an IOException, the watch layer can avoid this dependency by treating non-timeout IOExceptions as full-watch restarts, while preserving the existing SocketTimeoutException retry behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
