FrankChen021 commented on code in PR #19134:
URL: https://github.com/apache/druid/pull/19134#discussion_r3141585732
##########
.github/workflows/worker.yml:
##########
@@ -90,6 +90,25 @@ jobs:
run: ${{ inputs.script }}
timeout-minutes: 60
+ - name: Summarize flaky tests
+ if: ${{ hashFiles('**/TEST-*.xml') != '' }}
+ shell: bash
+ run: |
+ # Count flaky failures recursively
+ flaky_count=$(grep -R "<flakyFailure" . | wc -l)
+
+ echo "### Flaky Tests: $flaky_count found"
+
+ if [ "$flaky_count" -gt 0 ]; then
+ echo "#### Flaky Test Details"
+ grep -R "<flakyFailure" . | sed -E
's#.*/TEST-(.*)\.xml.*message="([^"]*)".*#- \1: \2#'
+ fi
+
+ - name: Normalize flaky failures
+ if: ${{ hashFiles('**/TEST-*.xml') != '' }}
+ run: |
+ find . -name "TEST-*.xml" -exec sed -i 's/flakyFailure/failure/g' {}
+
Review Comment:
P1 Flaky errors are still ignored by CI
The normalization only rewrites flakyFailure elements, but Maven Surefire
also emits flakyError for tests that error on an earlier attempt and pass on
rerun. Those XML entries will remain flaky-only, so
mikepenz/action-junit-report can still treat them as retries/flakes instead of
failing the job. This leaves a common class of intermittent test failures
hidden. The same handling should include flakyError -> error, and the
summary/count should include both tag types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
