jtuglu1 commented on code in PR #19353:
URL: https://github.com/apache/druid/pull/19353#discussion_r3135900320
##########
processing/src/main/java/org/apache/druid/query/topn/TopNQueryEngine.java:
##########
@@ -96,13 +98,34 @@ public Sequence<Result<TopNResultValue>> query(
if (cursorHolder.isPreAggregated()) {
query =
query.withAggregatorSpecs(Preconditions.checkNotNull(cursorHolder.getAggregatorsForPreAggregated()));
}
+
+ final TimeBoundaryInspector timeBoundaryInspector =
segment.as(TimeBoundaryInspector.class);
+
+ final boolean canVectorize = cursorHolder.canVectorize()
+ && VectorTopNEngine.canVectorize(query,
cursorFactory);
+ final boolean shouldVectorize =
query.context().getVectorize().shouldVectorize(canVectorize);
+
+ if (shouldVectorize) {
+ final ResourceHolder<ByteBuffer> bufHolder = bufferPool.take();
+ try {
+ final Closer resourceCloser = Closer.create();
+ resourceCloser.register(bufHolder);
+ resourceCloser.register(cursorHolder);
+ return Sequences.filter(
+ VectorTopNEngine.process(query, timeBoundaryInspector,
cursorHolder, bufHolder.get()),
+ Predicates.notNull()
+ ).withBaggage(resourceCloser);
Review Comment:
Something we should discuss is what algorithm/cursor metrics we want to
expose in the vectorized path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
