maytasm commented on PR #16234:
URL: https://github.com/apache/druid/pull/16234#issuecomment-4310896878
@vogievetsky @abhishekrb19
Out of curiosity, why don’t we apply this logic
(`changeLookupInExpressionsSampling`) in the Sampler API backend
(`SamplerResource`) instead of in the frontend?
If the Sampler API is guaranteed to return an error whenever there’s a
lookup in the spec, then applying the placeholder on the backend would help in
all cases where the Sampler API is called, not just from the Druid Console UI.
I also can't see any scenario where getting a 400 Bad Request error with
confusing error message (`"{"error":"Failed to sample data: Could not transform
value for xxx reason: yyy encountered unknown exception."}"`)`) would be
preferred to the placeholder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
