This is an automated email from the ASF dual-hosted git repository.
abhishekrb19 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 185bd2dfe08 minor: add getServiceDims() getter to ServiceMetricEvent
(#19350)
185bd2dfe08 is described below
commit 185bd2dfe0825df84f6173aafc4479d05de87d7a
Author: Abhishek Radhakrishnan <[email protected]>
AuthorDate: Mon Apr 20 10:14:58 2026 -0700
minor: add getServiceDims() getter to ServiceMetricEvent (#19350)
Adds a getServiceDims() getter method to ServiceMetricEvent to provide
direct access to the immutable service dimensions map. This can be used by
custom extensions along with the existing getters in the class.
---
.../java/util/emitter/service/ServiceMetricEvent.java | 5 +++++
.../util/emitter/service/ServiceMetricEventTest.java | 18 ++++++++++++++++++
2 files changed, 23 insertions(+)
diff --git
a/processing/src/main/java/org/apache/druid/java/util/emitter/service/ServiceMetricEvent.java
b/processing/src/main/java/org/apache/druid/java/util/emitter/service/ServiceMetricEvent.java
index 31f77a51283..6d214e627c2 100644
---
a/processing/src/main/java/org/apache/druid/java/util/emitter/service/ServiceMetricEvent.java
+++
b/processing/src/main/java/org/apache/druid/java/util/emitter/service/ServiceMetricEvent.java
@@ -93,6 +93,11 @@ public class ServiceMetricEvent implements Event
return serviceDims.get(HOST);
}
+ public Map<String, String> getServiceDims()
+ {
+ return serviceDims;
+ }
+
public Map<String, Object> getUserDims()
{
return userDims;
diff --git
a/processing/src/test/java/org/apache/druid/java/util/emitter/service/ServiceMetricEventTest.java
b/processing/src/test/java/org/apache/druid/java/util/emitter/service/ServiceMetricEventTest.java
index ec8345a8fe0..75a1cd4f083 100644
---
a/processing/src/test/java/org/apache/druid/java/util/emitter/service/ServiceMetricEventTest.java
+++
b/processing/src/test/java/org/apache/druid/java/util/emitter/service/ServiceMetricEventTest.java
@@ -76,6 +76,9 @@ public class ServiceMetricEventTest
builderEvent.toMap()
);
+ Assert.assertEquals("test", builderEvent.getServiceDims().get("service"));
+ Assert.assertEquals("localhost",
builderEvent.getServiceDims().get("host"));
+
ServiceMetricEvent constructorEvent = ServiceMetricEvent
.builder()
.setDimension("user1", "a")
@@ -333,6 +336,8 @@ public class ServiceMetricEventTest
final ServiceMetricEvent event1 = eventBuilder.build("coordinator",
"localhost");
Assert.assertEquals(Map.of("dim1", "v1"), event1.getUserDims());
+ Assert.assertEquals("coordinator", event1.getServiceDims().get("service"));
+ Assert.assertEquals("localhost", event1.getServiceDims().get("host"));
final ServiceMetricEvent event2 = eventBuilder
.setDimension("dim2", "v2")
@@ -342,6 +347,8 @@ public class ServiceMetricEventTest
// Verify that the original event gets changed dimensions
Assert.assertEquals(Map.of("dim1", "v1", "dim2", "v2"),
event2.getUserDims());
Assert.assertEquals(Map.of("dim1", "v1"), event1.getUserDims());
+ Assert.assertEquals("coordinator", event2.getServiceDims().get("service"));
+ Assert.assertEquals("localhost", event2.getServiceDims().get("host"));
}
@Test
@@ -380,4 +387,15 @@ public class ServiceMetricEventTest
new DefaultObjectMapper().writeValueAsString(event.toMap())
);
}
+
+ @Test
+ public void testGetServiceDims()
+ {
+ final ServiceMetricEvent event = ServiceMetricEvent.builder()
+
.setMetric("test-metric", 100)
+
.setDimension("userDim", "value")
+
.build(ImmutableMap.of("serviceDim1", "dim1", "serviceDim2", "dim2"));
+
+ Assert.assertEquals(ImmutableMap.of("serviceDim1", "dim1", "serviceDim2",
"dim2"), event.getServiceDims());
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
