abhishekrb19 commented on code in PR #19350:
URL: https://github.com/apache/druid/pull/19350#discussion_r3104150018
##########
processing/src/test/java/org/apache/druid/java/util/emitter/service/ServiceMetricEventTest.java:
##########
@@ -76,6 +76,9 @@ public void testBuilder()
builderEvent.toMap()
);
+ Assert.assertEquals("test", builderEvent.getServiceDims().get("service"));
Review Comment:
“service” and “host” are
[documented](https://druid.apache.org/docs/latest/operations/metrics/) metric
dimensions. Hence, they cannot change due to backward compatibility guarantees,
and this test and other existing ones that assert on the literals would catch
that unlikely drift.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
