jtuglu1 commented on code in PR #19342:
URL: https://github.com/apache/druid/pull/19342#discussion_r3097231746
##########
services/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java:
##########
@@ -770,12 +770,12 @@ public void onComplete(Result result)
failedQueryCount.incrementAndGet();
}
+ AuthenticationResult authenticationResult =
AuthorizationUtils.authenticationResultFromRequest(req);
+
// As router is simply a proxy, we don't make an effort to construct the
error code from the exception ourselves.
// We rely on broker to set this for us if the error occurs downstream.
// Otherwise, if there's a router/client error, we log this as an
unknown error.
- emitQueryTime(requestTimeNs, success, sqlQueryId, queryId, statusCode);
-
- AuthenticationResult authenticationResult =
AuthorizationUtils.authenticationResultFromRequest(req);
Review Comment:
I'll note this method can technically throw (and we'd skip metric emission
for this case) if there's no `AuthConfig.DRUID_AUTHENTICATION_RESULT`, but I
believe this should always be set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
