capistrant commented on PR #19327: URL: https://github.com/apache/druid/pull/19327#issuecomment-4261798872
> > Curious – why not just do all-at-once? > > idk, I was thinking it would minimize things like #19326 if migration was broken into smaller chunks, but no idea if that is actually true or not. Also, the github UI was pretty sad the last time i looked at a huge PR, so was thinking if i kept changes to ~1k lines people might actually glance over things before approving to double check stuff 🤷 > > I can do the rest of processing in one shot after this PR if people think that is better, I don't feel too strongly about it It is kind of nice to have it split up in the cases of files with more change than just the change to using `Assertions` everywhere. I have kind of been quick scanning those simple files and looking a little more deeply at ones that do more than that. In a big PR it would be tempting to just smash approve without looking or after looking at half :P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
