jtuglu1 commented on code in PR #19304:
URL: https://github.com/apache/druid/pull/19304#discussion_r3094697551
##########
processing/src/test/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequenceTest.java:
##########
@@ -542,11 +542,15 @@ public void testTimeoutExceptionDueToStalledInput()
"You can increase query timeout or tune the
performance of query.", t.getMessage());
- // these tests when run in java 11, 17 and maybe others in between 8 and
20 don't seem to correctly clean up the
- // pool, however this behavior is flaky and doesn't always happen so we
can't definitively assert that the pool is
- // or isn't
- if (JvmUtils.majorVersion() >= 20 || JvmUtils.majorVersion() < 9) {
- Assert.assertTrue(pool.awaitQuiescence(3, TimeUnit.SECONDS));
+ // JDK 11-23: pool may not clean up reliably after a timeout (flaky), so
we skip the assertion.
Review Comment:
done – scoped to 11-19.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
