Fly-Style commented on code in PR #19269:
URL: https://github.com/apache/druid/pull/19269#discussion_r3081399475
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java:
##########
@@ -174,11 +174,26 @@ public int computeTaskCountForScaleAction()
lastKnownMetrics = collectMetrics();
final int optimalTaskCount = computeOptimalTaskCount(lastKnownMetrics);
- final int currentTaskCount = supervisor.getIoConfig().getTaskCount();
+ int currentTaskCount = supervisor.getIoConfig().getTaskCount();
+
+ // Take the current task count but clamp it to the configured boundaries
if it is outside the boundaries.
+ // There might be a configuration instance with a handwritten taskCount
that is outside the boundaries.
+ final boolean isTaskCountOutOfBounds = currentTaskCount <
config.getTaskCountMin()
Review Comment:
Basically, in the code path when you're not having metrics you won't trigger
it. See:
You compute ``` final int optimalTaskCount =
computeOptimalTaskCount(lastKnownMetrics);```
and touch this value only after
```if (isScaleActionAllowed() && isTaskCountOutOfBounds)``` condition was
checked.
If this ^^^ condition works, the rest of the code path includes returning
`taskCount` from the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
