capistrant commented on code in PR #19300:
URL: https://github.com/apache/druid/pull/19300#discussion_r3080112644
##########
pom.xml:
##########
@@ -128,15 +128,15 @@
<jacoco.version>0.8.14</jacoco.version>
<testcontainers.version>2.0.3</testcontainers.version>
<hibernate-validator.version>6.2.5.Final</hibernate-validator.version>
- <httpclient.version>4.5.13</httpclient.version>
+ <httpclient.version>4.5.14</httpclient.version>
<okhttp.version>5.3.2</okhttp.version>
<kubernetes.client.version>25.0.0-legacy</kubernetes.client.version>
<zookeeper.version>3.8.6</zookeeper.version>
- <checkerframework.version>3.48.1</checkerframework.version>
- <com.google.apis.client.version>2.2.0</com.google.apis.client.version>
-
<com.google.http.client.apis.version>1.42.3</com.google.http.client.apis.version>
+ <checkerframework.version>3.49.0</checkerframework.version>
+ <com.google.apis.client.version>2.9.0</com.google.apis.client.version>
+
<com.google.http.client.apis.version>2.1.0</com.google.http.client.apis.version>
Review Comment:
any concerns around the major version bump and compatibility issues?
##########
embedded-tests/pom.xml:
##########
@@ -138,13 +138,13 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-storage</artifactId>
- <version>2.29.1</version>
+ <version>${com.google.cloud.storage.version}</version>
Review Comment:
should `google-cloud-storage` and `google-cloud-core` have their versions
put into root pom dep management area so they can be pulled in without explicit
version? if that makes it easier for this ET module and google-extensions
module to stay aligned on version if we want them level
##########
extensions-contrib/druid-ranger-security/pom.xml:
##########
@@ -39,7 +39,7 @@
<dependency>
<groupId>com.fasterxml.woodstox</groupId>
<artifactId>woodstox-core</artifactId>
- <version>6.4.0</version>
+ <version>7.0.0</version>
Review Comment:
Can we drop the explicit version now that woodstox-core is in the root pom
dependency management?
##########
pom.xml:
##########
@@ -112,7 +112,7 @@
<netty3.version>3.10.6.Final</netty3.version>
<netty4.version>4.2.12.Final</netty4.version>
<postgresql.version>42.7.2</postgresql.version>
- <protobuf.version>3.25.8</protobuf.version>
+ <protobuf.version>4.33.2</protobuf.version>
Review Comment:
any concerns around the major version change and compatibility issues?
##########
extensions-contrib/grpc-query/pom.xml:
##########
@@ -50,7 +50,7 @@
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-bom</artifactId>
- <version>1.70.0</version>
+ <version>1.80.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Review Comment:
can we be rid of this now thtat the BOM dependency is in the root pom in dep
management? and we can instead just have the deps on the modules we need from
the BOM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
