pirvtech commented on code in PR #19138:
URL: https://github.com/apache/druid/pull/19138#discussion_r3075340491
##########
processing/src/main/java/org/apache/druid/java/util/common/guava/Comparators.java:
##########
@@ -119,6 +119,34 @@ public int compare(Interval lhs, Interval rhs)
}
};
+ private static final Comparator<Interval> INTERVAL_BY_START = new
Comparator<>()
Review Comment:
In IntervalTree we need a separate start and end comparators as we need to
compare start and end times of intervals independently in different situations.
Unfortunately INTERVAL_BY_START_THEN_END for example, compares end time when
start times match and that leads to wrong results. I did initially try to use
the existing comparators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
