jtuglu1 commented on code in PR #19273:
URL: https://github.com/apache/druid/pull/19273#discussion_r3053015723


##########
pom.xml:
##########
@@ -70,7 +70,7 @@
     </scm>
 
     <properties>
-        <java.version>17</java.version>
+        <java.version>21</java.version>

Review Comment:
   I believe this was the plan all-along (wait for Hadoop 3.5 upgrade then bump 
to whatever latest JDK version this supports). Since Hadoop 3.5 
[supports](https://hadoop.apache.org/docs/r3.5.0/) JDK 21 client-side and it is 
the only thing preventing us from upgrading the compiler version, it seemed 
correct to do. Whether we wait for JDK 25+ support in Hadoop before decoupling 
it from critical extensions (e.g. Parquet) is IMO a separate issue, and we can 
in the meantime upgrade the compiler version. Let me know if you have any 
hesitations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to