hongkunxu commented on code in PR #18415:
URL: https://github.com/apache/druid/pull/18415#discussion_r3043966993
##########
processing/src/main/java/org/apache/druid/query/cache/CacheKeyBuilder.java:
##########
@@ -269,12 +271,12 @@ public CacheKeyBuilder appendFloatArray(float[] input)
public CacheKeyBuilder appendCacheable(@Nullable Cacheable input)
{
- byte[] cacheableToByteArray = cacheableToByteArray(input);
- if (cacheableToByteArray == null) {
+ final byte[] bytes = cacheableToByteArray(input);
+ if (bytes == null) {
invalidKey = true;
return this;
}
- appendItem(CACHEABLE_KEY, cacheableToByteArray);
+ appendItem(CACHEABLE_KEY, bytes);
Review Comment:
Since this PR has been open for quite some time and I no longer recall the
original context clearly, I revisited it and found the changes are unnecessary.
I’ve closed the PR. Thanks @GWphua for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
