capistrant opened a new pull request, #19250: URL: https://github.com/apache/druid/pull/19250
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. --> <!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. --> <!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. --> <!-- If you are a committer, follow the PR action item checklist for committers: https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. --> ### Description <!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. --> <!-- Describe your patch: what did you change in code? How did you fix the problem? --> <!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: --> A collection of web console improvements + an API correctness fix related to some Druid historical features (cloning, turbo loading, and decommissioning). The genesis of this is getting clones and turbo loading ready to take out of experimental and into GA. #### Clone Status API fix we weren't properly clearing out the clone status mapping when all clone mappings were deleted. this was leading to stale api responses saying clones existed that did not exist anymore #### Services View "Details" Column Added information to the Details column when it is able to be fetched: * `TURBO SEGMENT LOADING` will be displayed when a historical is in turbo loading mode * `DECOMMISSIONING` will be displayed when a historical is decommissioning * clone information will be displayed when a historical is cloning from another historical <img width="510" height="138" alt="image" src="https://github.com/user-attachments/assets/d6e82b0e-ee00-4d20-9df8-6f6a190db77b"; /> #### Coordinator Dynamic Config Form The form has been enhanced to improve operability of all three of turbo loading list, decom list, and clone mappings. **Previous State**: Decommissioning and Turbo were just text boxes in the form where you were supposed to manually manage lists of historical server ids. Clone mappings wasn't even exposed. you had to use the json tab in the web console if you wanted to modify clones via UI. **New State**: All 3 of these concepts now have a sub-form within the coordinator dynamic config form view Decommissioning and Turbo Loading have a selector situation where you can select what servers are to be included in the list <img width="513" height="286" alt="image" src="https://github.com/user-attachments/assets/f32c2e9d-eeac-4cb0-be51-b4cfd247fecd"; /> Clone mappings has an interactive map builder view where you create and delete clone mappings for historicals <img width="682" height="421" alt="image" src="https://github.com/user-attachments/assets/db49858b-0b80-4216-be00-9ca4f1d4f0c5"; /> A limitation of this new form state is that it uses existing servers in the form view(s) so you can't preemptively add servers that may not be online at the moment. This can still be accomplished either programmatically hitting the API or using the raw JSON form view in the UI. <!-- In each section, please describe design decisions made, including: - Choice of algorithms - Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources? - Class organization and design (how the logic is split between classes, inheritance, composition, design patterns) - Method organization and design (how the logic is split between methods, parameters and return types) - Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics) --> <!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. --> <!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. --> <!-- Some of the aspects mentioned above may be omitted for simple and small changes. --> #### Release note <!-- Give your best effort to summarize your changes in a couple of sentences aimed toward Druid users. If your change doesn't have end user impact, you can skip this section. For tips about how to write a good release note, see [Release notes](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#release-notes). --> Fix bug that was leading to stale historical clone status api responses when going from N clone mappings to 0 clone mappings. Enhance Web console with more rich support for managing historical decommissioning, cloning, and turbo loading <hr> ##### Key changed/added classes in this PR <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [ ] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
