clintropolis opened a new pull request, #19245: URL: https://github.com/apache/druid/pull/19245
### Description changes: * `ExpressionFilter.canVectorizeMatcher` and `AggregatorUtil.canVectorize` now use `ExpressionPlanner.plan` to check for `Trait.VECTORIZABLE` instead of calling `Expr.canVectorize` directly * updated javadoc for `Expr.canVectorize` to indicate that it alone isn't sufficient to decide if vector processing should be used * update `BaseFilterTest.assertFilterMatchesSkipVectorize` to now assert that the cursor factory is not vectorizable (or not a `ColumnarFrameCursorFactory`) so that we do not accidentally skip vectorization for things that are vectorizable, which would have caught the bug for `ExpressionFilter`, fixed up tests that were incorrectly skipping vector coverage * update `AggregatorUtilTest` to cover `canVectorize` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
