This is an automated email from the ASF dual-hosted git repository.
gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new e358a268672 minor: FrameCombiner related cleanups. (#19244)
e358a268672 is described below
commit e358a2686724efd452b2102a99f87adb359c41b9
Author: Gian Merlino <[email protected]>
AuthorDate: Tue Mar 31 16:58:31 2026 -0700
minor: FrameCombiner related cleanups. (#19244)
Follow-ups to #19238:
1) Remove a stale comment in GroupByFrameCombinerTest.
2) Make TrackingColumnValueSelector.classOfObject() call its delegate,
just like TrackingDimensionSelector does. This likely doesn't matter
with how the class is actually used, but it's nice to be consistent.
---
.../apache/druid/msq/querykit/groupby/GroupByFrameCombinerTest.java | 5 -----
.../apache/druid/frame/processor/TrackingColumnValueSelector.java | 2 +-
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git
a/multi-stage-query/src/test/java/org/apache/druid/msq/querykit/groupby/GroupByFrameCombinerTest.java
b/multi-stage-query/src/test/java/org/apache/druid/msq/querykit/groupby/GroupByFrameCombinerTest.java
index 70dd858f0ed..b32d619438b 100644
---
a/multi-stage-query/src/test/java/org/apache/druid/msq/querykit/groupby/GroupByFrameCombinerTest.java
+++
b/multi-stage-query/src/test/java/org/apache/druid/msq/querykit/groupby/GroupByFrameCombinerTest.java
@@ -60,11 +60,6 @@ import java.util.stream.IntStream;
/**
* Tests for {@link GroupByFrameCombiner} used with {@link FrameChannelMerger}.
- *
- * The existing combiner tests in SuperSorterTest use {@link
org.apache.druid.frame.processor.SummingFrameCombiner},
- * which creates a new ColumnSelectorFactory each call to
getCombinedColumnSelectorFactory(). That avoids the bug
- * where dimension selectors become stale when the underlying frame cursor
changes. This test uses the real
- * {@link GroupByFrameCombiner} to verify correct behavior across frame
boundaries.
*/
public class GroupByFrameCombinerTest extends InitializedNullHandlingTest
{
diff --git
a/processing/src/main/java/org/apache/druid/frame/processor/TrackingColumnValueSelector.java
b/processing/src/main/java/org/apache/druid/frame/processor/TrackingColumnValueSelector.java
index f1e46b338c2..22413e55559 100644
---
a/processing/src/main/java/org/apache/druid/frame/processor/TrackingColumnValueSelector.java
+++
b/processing/src/main/java/org/apache/druid/frame/processor/TrackingColumnValueSelector.java
@@ -89,7 +89,7 @@ public class TrackingColumnValueSelector implements
ColumnValueSelector<Object>
@Override
public Class<?> classOfObject()
{
- return Object.class;
+ return delegate().classOfObject();
}
@Override
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
