gianm opened a new pull request, #19233: URL: https://github.com/apache/druid/pull/19233
In PRs #18095 and #18931, worker cancellation was switched to use interrupts with a lightweight non-interrupt-based failsafe. This patch implements a similar idea for controllers, to aid in more prompt cancellation in cases where the controller is blocking on something. The main change is to track the controller thread in `ControllerHolder` and interrupt it on `cancel()`, in addition to calling `controller.stop()`. ControllerHolder is also moved from `dart.controller` to `msq.exec`, since it is now a shared class, no longer Dart-specific. In addition, the `workerOffline` logic is moved to Dart's `ControllerMessageListener`, since that really is Dart-specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
