clintropolis opened a new pull request, #19217: URL: https://github.com/apache/druid/pull/19217
changes: * adds `storage/virtual/hold/count` and `storage/virtual/hold/bytes` to `StorageMonitor` to track actively held weak cache entries * fixes a bug with `StorageLocation` when using `freeSpaceToKeep` where if the second call to reclaim to obtain additional space failed, `StorageLocation` would neither restore or unmount the entries, leaving behind orphans. Fixes by adjusting things so that we only call reclaim once and adjust the size based on whether we are trying to maintain `freeSpaceToKeep` or not * fixes an unlikely bug with `StorageLocation` of reclaim leaving orphan entries if all entries needed to be evicted to satisfy the request, which would fail but not restore or unmount any entries (unlikely to occur since it would mean the reclaim request was for something that could not fit in a completely empty cache, at least until we allow mixing weak and static entries..). * fixes an issue with StorageLocation eviction stats, which were eagerly counted instead of waiting to ensure that the entries were actually going to be evicted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
