clintropolis commented on code in PR #19146:
URL: https://github.com/apache/druid/pull/19146#discussion_r2976804435
##########
processing/src/main/java/org/apache/druid/data/input/impl/StringDimensionSchema.java:
##########
@@ -40,15 +51,33 @@ public static StringDimensionSchema create(String name)
public StringDimensionSchema(
@JsonProperty("name") String name,
@JsonProperty("multiValueHandling") MultiValueHandling
multiValueHandling,
- @JsonProperty("createBitmapIndex") Boolean createBitmapIndex
+ @JsonProperty("createBitmapIndex") Boolean createBitmapIndex,
+ @JsonProperty("maxStringLength") @Nullable Integer maxStringLength
Review Comment:
my preference would be that this refactor is done before a release that
contains it so that we don't have to support both styles of configuration,
apologies I didn't have a chance to do a review before it was merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
