aho135 commented on code in PR #19146:
URL: https://github.com/apache/druid/pull/19146#discussion_r2956985811
##########
processing/src/main/java/org/apache/druid/guice/BuiltInTypesModule.java:
##########
@@ -53,6 +53,7 @@ public class BuiltInTypesModule implements DruidModule
*/
private static DimensionSchema.MultiValueHandling STRING_MV_MODE =
DimensionSchema.MultiValueHandling.SORTED_ARRAY;
private static IndexSpec DEFAULT_INDEX_SPEC = IndexSpec.builder().build();
+ private static int MAX_STRING_LENGTH = 0;
Review Comment:
Would it make sense to set this to Integer max value? In case this is used
elsewhere in the future there wouldn't need to explicit handling for 0 like you
have in truncateIfNeeded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
