This is an automated email from the ASF dual-hosted git repository.
capistrant pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 7913d036acf MSQ: Restore memory-access optimization during sorting.
(#19170)
7913d036acf is described below
commit 7913d036acf1c350688a0c63eb411e4d9cc890b0
Author: Gian Merlino <[email protected]>
AuthorDate: Tue Mar 17 08:54:10 2026 -0700
MSQ: Restore memory-access optimization during sorting. (#19170)
Due to a mistake in #18181, the direct row-memory-access optimization
was lost for outputs of FrameChannelHashPartitioner and
FrameChannelMerger. This patch restores it, which should speed up
hash partitioning, range partitioning, and sorting in general.
---
.../org/apache/druid/frame/processor/MultiColumnSelectorFactory.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/processing/src/main/java/org/apache/druid/frame/processor/MultiColumnSelectorFactory.java
b/processing/src/main/java/org/apache/druid/frame/processor/MultiColumnSelectorFactory.java
index 341cbc31907..6384f4599a4 100644
---
a/processing/src/main/java/org/apache/druid/frame/processor/MultiColumnSelectorFactory.java
+++
b/processing/src/main/java/org/apache/druid/frame/processor/MultiColumnSelectorFactory.java
@@ -65,7 +65,8 @@ public class MultiColumnSelectorFactory implements
ColumnSelectorFactory
}
/**
- * Create a copy that includes {@link
FrameColumnSelectorFactory#ROW_SIGNATURE_COLUMN} and
+ * Create a copy that includes {@link
FrameColumnSelectorFactory#FRAME_TYPE_COLUMN},
+ * {@link FrameColumnSelectorFactory#ROW_SIGNATURE_COLUMN}, and
* {@link FrameColumnSelectorFactory#ROW_MEMORY_COLUMN} to potentially
enable direct row memory copying. If these
* columns don't actually exist in the underlying column selector factories,
they'll be ignored, so it's OK to
* use this method even if the columns may not exist.
@@ -76,6 +77,7 @@ public class MultiColumnSelectorFactory implements
ColumnSelectorFactory
factorySuppliers,
RowSignature.builder()
.addAll(signature)
+ .add(FrameColumnSelectorFactory.FRAME_TYPE_COLUMN,
ColumnType.UNKNOWN_COMPLEX)
.add(FrameColumnSelectorFactory.ROW_SIGNATURE_COLUMN,
ColumnType.UNKNOWN_COMPLEX)
.add(FrameColumnSelectorFactory.ROW_MEMORY_COLUMN,
ColumnType.UNKNOWN_COMPLEX)
.build()
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
