gianm commented on code in PR #19162:
URL: https://github.com/apache/druid/pull/19162#discussion_r2944542998
##########
server/src/main/java/org/apache/druid/segment/metadata/AbstractSegmentMetadataCache.java:
##########
@@ -991,11 +991,6 @@ static RowSignature analysisToRowSignature(final
SegmentAnalysis analysis)
{
final RowSignature.Builder rowSignatureBuilder = RowSignature.builder();
for (Map.Entry<String, ColumnAnalysis> entry :
analysis.getColumns().entrySet()) {
- if (entry.getValue().isError()) {
Review Comment:
> As for why this happens here, I’m not entirely sure....but these were
happening only on the realtime tasks in our case.
Ah, they're probably trying to merge the analyses from different persists.
Are you using auto typing? Either `type: auto` for a dimension spec or
`useSchemaDiscovery: true`? I wonder if there is some issue when different
persists select different types for the same column. That kind of thing is
generally reconciled at query time and also reconciled when the segment was
built and merged, but maybe we missed a place where it needs to be reconciled
in the `segmentMetadata` path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
