clintropolis commented on code in PR #19061:
URL: https://github.com/apache/druid/pull/19061#discussion_r2943187378
##########
multi-stage-query/src/main/java/org/apache/druid/msq/indexing/processor/SegmentGeneratorStageProcessor.java:
##########
@@ -80,17 +83,20 @@ public class SegmentGeneratorStageProcessor implements
StageProcessor<Set<DataSe
{
private final DataSchema dataSchema;
private final ColumnMappings columnMappings;
+ private final Map<String, VirtualColumn> clusterByVirtualColumnMappings;
Review Comment:
this must not have mattered all that much, `DataSchema` also didn't
implement equals and hashcode, and after adding it i see why was skipped, was
kind of wonky with some lazy initialization of stuff, but between #19109 and
#19166 we will soon be able to drop the parser stuff from it completely, so i
went ahead and changed it to be eager for now, added equalsverifier tests for
both `DataSchema` and `SegmentGeneratorStageProcessor`... i may revert this if
it has too much trouble in CI, since there were quite a lot of failures just in
`DataSchemaTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
