gianm opened a new pull request, #19161: URL: https://github.com/apache/druid/pull/19161
When MonitorScheduler "stop" is called, it in turn calls "removeMonitor". This calls "monitor" on all monitors. The whole process is synchronized on the MonitorScheduler itself, but it is not synchronized with the regularly-scheduled calls to "monitor". It can lead to "monitor" running concurrently with itself, which can lead to unpredictable behavior in metrics emission. One likely effect of this would be to emit metrics twice, due to the common pattern of snapshot -> emit deltas from previous snapshot -> save snapshot. This patch also removes the unused CompoundMonitor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
