kfaraz commented on code in PR #18891:
URL: https://github.com/apache/druid/pull/18891#discussion_r2915989699
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/minio/ITS3ToS3ParallelIndexTest.java:
##########
@@ -40,7 +39,11 @@ public void testS3IndexData(Pair<String, List<?>>
s3InputSource) throws Exceptio
@MethodSource("resources")
public void testS3IndexData_withTempCredentials(Pair<String, List<?>>
s3InputSource) throws Exception
{
- final S3InputSourceConfig inputSourceConfig =
minIOStorageResource.createTempCredentialsForInputSource();
- doTest(s3InputSource, new Pair<>(false, false), "s3", inputSourceConfig);
+ doTestWithEndpointConfig(
Review Comment:
Please avoid resolving comments if they are not being addressed. 🙂
It makes it difficult for the reviewer to figure out why a change should not
be made.
In such cases, it is best to add a reply clarifying why the change is not
needed and leave the comment unresolved to keep the discussion open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
