abhishekrb19 commented on PR #19026: URL: https://github.com/apache/druid/pull/19026#issuecomment-4015312750
> Could we make this functionality generic to all types of emitters? Agreed, this will be broadly useful as a core concept for all emitters. Can we do this as a separate change though and scope this PR down to only add the functionality for the LoggingEmitter as mentioned in https://github.com/apache/druid/issues/19021? Existing emitters like prometheus-emitter, dropwizard-emitter, opentsdb-emitter, etc. already have a notion of an allow list, so we’ll need to be careful not to break compatibility with them. IMO it will be better to come up with a common interface and enable it for all the emitters in a backwards-compatible manner to existing emitters in a separate change (or alternatively define the interface in this patch, but only integrate it with the LoggingEmitter, but I'd prefer that we do this separately too). Please let me know what you think @nozjkoitop @jtuglu1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
